bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Minor let_chains modification

Browse source
This commit is contained in:
Caio 2022-03-25 18:50:52 -03:00
parent 09be68c869
commit 9e0b7c3f44
2 changed files with 15 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_ast_passes/src/ast_validation.rs
View file

@ -122,7 +122,10 @@ impl<'a> AstValidator<'a> {
diag.note("only supported directly in conditions of `if` and `while` expressions"); diag.note("only supported directly in conditions of `if` and `while` expressions");
diag.note("as well as when nested within `&&` and parentheses in those conditions"); diag.note("as well as when nested within `&&` and parentheses in those conditions");
if let ForbiddenLetReason::ForbiddenWithOr(span) = forbidden_let_reason { if let ForbiddenLetReason::ForbiddenWithOr(span) = forbidden_let_reason {
diag.span_note(span, "`||` operators are not allowed in let chain expressions"); diag.span_note(
span,
"`||` operators are not currently supported in let chain expressions",
);
} }
diag.emit(); diag.emit();
} else { } else {

22
src/test/ui/rfc-2497-if-let-chains/disallowed-positions.stderr
View file

@ -62,7 +62,7 @@ LL | if true || let 0 = 0 {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:47:13 --> $DIR/disallowed-positions.rs:47:13
| |
LL | if true || let 0 = 0 {} LL | if true || let 0 = 0 {}
@ -76,7 +76,7 @@ LL | if (true || let 0 = 0) {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:48:14 --> $DIR/disallowed-positions.rs:48:14
| |
LL | if (true || let 0 = 0) {} LL | if (true || let 0 = 0) {}
@ -90,7 +90,7 @@ LL | if true && (true || let 0 = 0) {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:49:22 --> $DIR/disallowed-positions.rs:49:22
| |
LL | if true && (true || let 0 = 0) {} LL | if true && (true || let 0 = 0) {}
@ -104,7 +104,7 @@ LL | if true || (true && let 0 = 0) {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:50:13 --> $DIR/disallowed-positions.rs:50:13
| |
LL | if true || (true && let 0 = 0) {} LL | if true || (true && let 0 = 0) {}
@ -244,7 +244,7 @@ LL | while true || let 0 = 0 {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:111:16 --> $DIR/disallowed-positions.rs:111:16
| |
LL | while true || let 0 = 0 {} LL | while true || let 0 = 0 {}
@ -258,7 +258,7 @@ LL | while (true || let 0 = 0) {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:112:17 --> $DIR/disallowed-positions.rs:112:17
| |
LL | while (true || let 0 = 0) {} LL | while (true || let 0 = 0) {}
@ -272,7 +272,7 @@ LL | while true && (true || let 0 = 0) {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:113:25 --> $DIR/disallowed-positions.rs:113:25
| |
LL | while true && (true || let 0 = 0) {} LL | while true && (true || let 0 = 0) {}
@ -286,7 +286,7 @@ LL | while true || (true && let 0 = 0) {}
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:114:16 --> $DIR/disallowed-positions.rs:114:16
| |
LL | while true || (true && let 0 = 0) {} LL | while true || (true && let 0 = 0) {}
@ -426,7 +426,7 @@ LL | true || let 0 = 0;
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:184:10 --> $DIR/disallowed-positions.rs:184:10
| |
LL | true || let 0 = 0; LL | true || let 0 = 0;
@ -440,7 +440,7 @@ LL | (true || let 0 = 0);
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:185:11 --> $DIR/disallowed-positions.rs:185:11
| |
LL | (true || let 0 = 0); LL | (true || let 0 = 0);
@ -454,7 +454,7 @@ LL | true && (true || let 0 = 0);
| |
= note: only supported directly in conditions of `if` and `while` expressions = note: only supported directly in conditions of `if` and `while` expressions
= note: as well as when nested within `&&` and parentheses in those conditions = note: as well as when nested within `&&` and parentheses in those conditions
note: `||` operators are not allowed in let chain expressions note: `||` operators are not currently supported in let chain expressions
--> $DIR/disallowed-positions.rs:186:19 --> $DIR/disallowed-positions.rs:186:19
| |
LL | true && (true || let 0 = 0); LL | true && (true || let 0 = 0);