Show used attribute
's kind for user when find it isn't applied to a static
variable.
fixes #126789
This commit is contained in:
parent
4e63822fc4
commit
9c0ce05d24
6 changed files with 35 additions and 3 deletions
|
@ -786,6 +786,7 @@ passes_used_compiler_linker =
|
||||||
|
|
||||||
passes_used_static =
|
passes_used_static =
|
||||||
attribute must be applied to a `static` variable
|
attribute must be applied to a `static` variable
|
||||||
|
.label = but this is a {$target}
|
||||||
|
|
||||||
passes_useless_assignment =
|
passes_useless_assignment =
|
||||||
useless assignment of {$is_field_assign ->
|
useless assignment of {$is_field_assign ->
|
||||||
|
|
|
@ -278,7 +278,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
|
||||||
}
|
}
|
||||||
|
|
||||||
self.check_repr(attrs, span, target, item, hir_id);
|
self.check_repr(attrs, span, target, item, hir_id);
|
||||||
self.check_used(attrs, target);
|
self.check_used(attrs, target, span);
|
||||||
}
|
}
|
||||||
|
|
||||||
fn inline_attr_str_error_with_macro_def(&self, hir_id: HirId, attr: &Attribute, sym: &str) {
|
fn inline_attr_str_error_with_macro_def(&self, hir_id: HirId, attr: &Attribute, sym: &str) {
|
||||||
|
@ -1978,12 +1978,16 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn check_used(&self, attrs: &[Attribute], target: Target) {
|
fn check_used(&self, attrs: &[Attribute], target: Target, target_span: Span) {
|
||||||
let mut used_linker_span = None;
|
let mut used_linker_span = None;
|
||||||
let mut used_compiler_span = None;
|
let mut used_compiler_span = None;
|
||||||
for attr in attrs.iter().filter(|attr| attr.has_name(sym::used)) {
|
for attr in attrs.iter().filter(|attr| attr.has_name(sym::used)) {
|
||||||
if target != Target::Static {
|
if target != Target::Static {
|
||||||
self.dcx().emit_err(errors::UsedStatic { span: attr.span });
|
self.dcx().emit_err(errors::UsedStatic {
|
||||||
|
attr_span: attr.span,
|
||||||
|
span: target_span,
|
||||||
|
target: target.name(),
|
||||||
|
});
|
||||||
}
|
}
|
||||||
let inner = attr.meta_item_list();
|
let inner = attr.meta_item_list();
|
||||||
match inner.as_deref() {
|
match inner.as_deref() {
|
||||||
|
|
|
@ -563,7 +563,10 @@ pub struct ReprConflictingLint;
|
||||||
#[diag(passes_used_static)]
|
#[diag(passes_used_static)]
|
||||||
pub struct UsedStatic {
|
pub struct UsedStatic {
|
||||||
#[primary_span]
|
#[primary_span]
|
||||||
|
pub attr_span: Span,
|
||||||
|
#[label]
|
||||||
pub span: Span,
|
pub span: Span,
|
||||||
|
pub target: &'static str,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Diagnostic)]
|
#[derive(Diagnostic)]
|
||||||
|
|
6
tests/ui/attributes/used-issue-126789.rs
Normal file
6
tests/ui/attributes/used-issue-126789.rs
Normal file
|
@ -0,0 +1,6 @@
|
||||||
|
extern "C" {
|
||||||
|
#[used] //~ ERROR attribute must be applied to a `static` variable
|
||||||
|
static FOO: i32;
|
||||||
|
}
|
||||||
|
|
||||||
|
fn main() {}
|
10
tests/ui/attributes/used-issue-126789.stderr
Normal file
10
tests/ui/attributes/used-issue-126789.stderr
Normal file
|
@ -0,0 +1,10 @@
|
||||||
|
error: attribute must be applied to a `static` variable
|
||||||
|
--> $DIR/used-issue-126789.rs:2:5
|
||||||
|
|
|
||||||
|
LL | #[used]
|
||||||
|
| ^^^^^^^
|
||||||
|
LL | static FOO: i32;
|
||||||
|
| ---------------- but this is a foreign static item
|
||||||
|
|
||||||
|
error: aborting due to 1 previous error
|
||||||
|
|
|
@ -3,24 +3,32 @@ error: attribute must be applied to a `static` variable
|
||||||
|
|
|
|
||||||
LL | #[used]
|
LL | #[used]
|
||||||
| ^^^^^^^
|
| ^^^^^^^
|
||||||
|
LL | fn foo() {}
|
||||||
|
| ----------- but this is a function
|
||||||
|
|
||||||
error: attribute must be applied to a `static` variable
|
error: attribute must be applied to a `static` variable
|
||||||
--> $DIR/used.rs:7:1
|
--> $DIR/used.rs:7:1
|
||||||
|
|
|
|
||||||
LL | #[used]
|
LL | #[used]
|
||||||
| ^^^^^^^
|
| ^^^^^^^
|
||||||
|
LL | struct Foo {}
|
||||||
|
| ------------- but this is a struct
|
||||||
|
|
||||||
error: attribute must be applied to a `static` variable
|
error: attribute must be applied to a `static` variable
|
||||||
--> $DIR/used.rs:10:1
|
--> $DIR/used.rs:10:1
|
||||||
|
|
|
|
||||||
LL | #[used]
|
LL | #[used]
|
||||||
| ^^^^^^^
|
| ^^^^^^^
|
||||||
|
LL | trait Bar {}
|
||||||
|
| ------------ but this is a trait
|
||||||
|
|
||||||
error: attribute must be applied to a `static` variable
|
error: attribute must be applied to a `static` variable
|
||||||
--> $DIR/used.rs:13:1
|
--> $DIR/used.rs:13:1
|
||||||
|
|
|
|
||||||
LL | #[used]
|
LL | #[used]
|
||||||
| ^^^^^^^
|
| ^^^^^^^
|
||||||
|
LL | impl Bar for Foo {}
|
||||||
|
| ------------------- but this is a implementation block
|
||||||
|
|
||||||
error: aborting due to 4 previous errors
|
error: aborting due to 4 previous errors
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue