bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #98261 - WaffleLapkin:attempt_to_remove_max_suggestion_highlight_lines, r=flip1995

Browse source 
Remove `MAX_SUGGESTION_HIGHLIGHT_LINES`

After #97798 the `MAX_SUGGESTION_HIGHLIGHT_LINES` constant doesn't really make sense since we always show full suggestions. This PR removes last usages of the constant and the constant itself.

r? ``@flip1995`` (this mostly does changes in clippy)
This commit is contained in:
Dylan DPC 2022-06-28 15:30:01 +05:30 • committed by GitHub
commit 9b3dbb8200
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 68 additions and 186 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_errors/src/emitter.rs
View file

@ -656,11 +656,6 @@ impl Emitter for SilentEmitter {
}
}
/// Maximum number of lines we will print for a multiline suggestion; arbitrary.
///
/// This should be replaced with a more involved mechanism to output multiline suggestions that
/// more closely mimics the regular diagnostic output, where irrelevant code lines are elided.
pub const MAX_SUGGESTION_HIGHLIGHT_LINES: usize = 6;
/// Maximum number of suggestions to be shown
///
/// Arbitrary, but taken from trait import suggestion limit