bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Add warning for a parameter list with an attribute but no parameters

Browse source
This commit is contained in:
varkor 2019-02-07 14:58:31 +01:00
parent dbc7924b3f
commit 9ad04b9960
3 changed files with 28 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/libsyntax/parse/parser.rs
View file

@ -5545,13 +5545,25 @@ impl<'a> Parser<'a> {
params.push(self.parse_ty_param(attrs)?);
} else {
// Check for trailing attributes and stop parsing.
if !attrs.is_empty() && !params.is_empty() {
self.struct_span_err(
attrs[0].span,
&format!("trailing attribute after generic parameter"),
)
.span_label(attrs[0].span, "attributes must go before parameters")
.emit();
if !attrs.is_empty() {
if !params.is_empty() {
self.struct_span_err(
attrs[0].span,
&format!("trailing attribute after generic parameter"),
)
.span_label(attrs[0].span, "attributes must go before parameters")
.emit();
} else {
self.struct_span_err(
attrs[0].span,
&format!("attribute without generic parameters"),
)
.span_label(
attrs[0].span,
"attributes are only permitted when preceding parameters",
)
.emit();
}
}
break
}