bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Make unused_allocation lint warn against Box::new

Browse source
This commit is contained in:
Maybe Waffle 2022-11-13 13:55:04 +00:00
parent 18caf88956
commit 9ac0da8f39
3 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_lint/src/unused.rs
View file

@ -1349,9 +1349,8 @@ declare_lint! {
/// ### Example
///
/// ```rust
/// #![feature(box_syntax)]
/// fn main() {
/// let a = (box [1, 2, 3]).len();
/// let a = Box::new([1, 2, 3]).len();
/// }
/// ```
///
@ -1373,6 +1372,11 @@ impl<'tcx> LateLintPass<'tcx> for UnusedAllocation {
fn check_expr(&mut self, cx: &LateContext<'_>, e: &hir::Expr<'_>) {
match e.kind {
hir::ExprKind::Box(_) => {}
hir::ExprKind::Call(path_expr, [_])
if let hir::ExprKind::Path(qpath) = &path_expr.kind
&& let Some(did) = cx.qpath_res(qpath, path_expr.hir_id).opt_def_id()
&& cx.tcx.is_diagnostic_item(sym::box_new, did)
=> {}
_ => return,
}