bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Split Handler::emit_diagnostic in two.

Browse source 
Currently, `emit_diagnostic` takes `&mut self`.

This commit changes it so `emit_diagnostic` takes `self` and the new
`emit_diagnostic_without_consuming` function takes `&mut self`.

I find the distinction useful. The former case is much more common, and
avoids a bunch of `mut` and `&mut` occurrences. We can also restrict the
latter with `pub(crate)` which is nice.
This commit is contained in:
Nicholas Nethercote 2023-12-14 14:13:35 +11:00
parent 2c2c7f13a6
commit 9a78412511
12 changed files with 64 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_query_system/src/dep_graph/graph.rs
View file

@ -926,8 +926,8 @@ impl<D: Deps> DepGraphData<D> {
let handle = qcx.dep_context().sess().diagnostic();
for mut diagnostic in side_effects.diagnostics {
handle.emit_diagnostic(&mut diagnostic);
for diagnostic in side_effects.diagnostics {
handle.emit_diagnostic(diagnostic);
}
}
}