bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #126177 - carbotaniuman:unsafe_attr_errors, r=jieyouxu

Browse source 
Add hard error and migration lint for unsafe attrs

More implementation work for https://github.com/rust-lang/rust/issues/123757

This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.
This commit is contained in:
Matthias Krüger 2024-06-24 06:27:12 +02:00 • committed by GitHub
commit 9a591ea1ce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
24 changed files with 473 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_feature/src/builtin_attrs.rs
View file

@ -1145,10 +1145,6 @@ pub fn is_valid_for_get_attr(name: Symbol) -> bool {
})
}
pub fn is_unsafe_attr(name: Symbol) -> bool {
BUILTIN_ATTRIBUTE_MAP.get(&name).is_some_and(|attr| attr.safety == AttributeSafety::Unsafe)
}
pub static BUILTIN_ATTRIBUTE_MAP: LazyLock<FxHashMap<Symbol, &BuiltinAttribute>> =
LazyLock::new(|| {
let mut map = FxHashMap::default();

2
compiler/rustc_feature/src/lib.rs
View file

@ -125,7 +125,7 @@ pub use accepted::ACCEPTED_FEATURES;
pub use builtin_attrs::AttributeDuplicates;
pub use builtin_attrs::{
deprecated_attributes, encode_cross_crate, find_gated_cfg, is_builtin_attr_name,
is_unsafe_attr, is_valid_for_get_attr, AttributeGate, AttributeTemplate, AttributeType,
is_valid_for_get_attr, AttributeGate, AttributeSafety, AttributeTemplate, AttributeType,
BuiltinAttribute, GatedCfg, BUILTIN_ATTRIBUTES, BUILTIN_ATTRIBUTE_MAP,
};
pub use removed::REMOVED_FEATURES;