bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #87408 - kornelski:try_reserve_error, r=yaahc

Browse source 
Hide allocator details from TryReserveError

I think there's [no need for TryReserveError to carry detailed information](https://github.com/rust-lang/rust/issues/48043#issuecomment-825139280), but I wouldn't want that issue to delay stabilization of the `try_reserve` feature.

So I'm proposing to stabilize `try_reserve` with a `TryReserveError` as an opaque structure, and if needed, expose error details later.

This PR moves the `enum` to an unstable inner `TryReserveErrorKind` that lives under a separate feature flag. `TryReserveErrorKind` could possibly be left as an implementation detail forever, and the `TryReserveError` get methods such as `allocation_size() -> Option<usize>` or `layout() -> Option<Layout>` instead, or the details could be dropped completely to make try-reserve errors just a unit struct, and thus smaller and cheaper.
This commit is contained in:
bors 2021-08-07 01:26:15 +00:00
commit 996ff2e0a0
13 changed files with 269 additions and 109 deletions
Download patch file Download diff file Expand all files Collapse all files

1
compiler/rustc_mir/src/lib.rs
View file

@ -30,6 +30,7 @@ Rust MIR: a lowered representation of Rust.
#![feature(once_cell)]
#![feature(control_flow_enum)]
#![feature(try_reserve)]
#![feature(try_reserve_kind)]
#![recursion_limit = "256"]
#[macro_use]