bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

remove no-op logic

Browse source
This commit is contained in:
Lukas Markeffsky 2023-05-12 23:13:30 +02:00
parent 4a59ba4d54
commit 97ed808322
1 changed files with 2 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

15
compiler/rustc_mir_transform/src/deduce_param_attrs.rs
View file

@ -29,25 +29,14 @@ impl DeduceReadOnly {
} }
impl<'tcx> Visitor<'tcx> for DeduceReadOnly { impl<'tcx> Visitor<'tcx> for DeduceReadOnly {
fn visit_local(&mut self, local: Local, mut context: PlaceContext, _: Location) { fn visit_local(&mut self, local: Local, context: PlaceContext, _location: Location) {
// We're only interested in arguments. // We're only interested in arguments.
if local == RETURN_PLACE || local.index() > self.mutable_args.domain_size() { if local == RETURN_PLACE || local.index() > self.mutable_args.domain_size() {
return; return;
} }
// Replace place contexts that are moves with copies. This is safe in all cases except
// function argument position, which we already handled in `visit_terminator()` by using the
// ArgumentChecker. See the comment in that method for more details.
//
// In the future, we might want to move this out into a separate pass, but for now let's
// just do it on the fly because that's faster.
if matches!(context, PlaceContext::NonMutatingUse(NonMutatingUseContext::Move)) {
context = PlaceContext::NonMutatingUse(NonMutatingUseContext::Copy);
}
match context { match context {
PlaceContext::MutatingUse(..) PlaceContext::MutatingUse(..) => {
| PlaceContext::NonMutatingUse(NonMutatingUseContext::Move) => {
// This is a mutation, so mark it as such. // This is a mutation, so mark it as such.
self.mutable_args.insert(local.index() - 1); self.mutable_args.insert(local.index() - 1);
} }