bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Move object safety suggestions to the end of the error

Browse source
This commit is contained in:
Esteban Kuber 2021-09-12 18:49:56 +00:00
parent e846f9c44f
commit 9762116299
28 changed files with 50 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_infer/src/traits/error_reporting/mod.rs
View file

@ -83,10 +83,6 @@ pub fn report_object_safety_error(
messages.push(msg.clone());
}
}
if trait_span.is_some() {
// Only provide the help if its a local trait, otherwise it's not actionable.
violation.solution(&mut err);
}
}
}
let has_multi_span = !multi_span.is_empty();
@ -104,5 +100,13 @@ pub fn report_object_safety_error(
to be resolvable dynamically; for more information visit \
<https://doc.rust-lang.org/reference/items/traits.html#object-safety>",
);
if trait_span.is_some() {
let mut reported_violations: Vec<_> = reported_violations.into_iter().collect();
reported_violations.sort();
for violation in reported_violations {
// Only provide the help if its a local trait, otherwise it's not actionable.
violation.solution(&mut err);
}
}
err
}