bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Remove FIXME

Browse source 
This resolves the concern in favor of prohibiting multiple instances of
the attribute. This is similar to non-helper attributes as introduced in
#88681.
This commit is contained in:
Jacob Pratt 2021-12-28 13:51:14 -05:00
parent 442248d6bc
commit 969fee6cbe
No known key found for this signature in database
GPG key ID: B80E19E4662B5AA4
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_builtin_macros/src/deriving/default.rs
View file

@ -222,9 +222,6 @@ fn validate_default_attribute(
"this method must only be called with a variant that has a `#[default]` attribute", "this method must only be called with a variant that has a `#[default]` attribute",
), ),
[first, rest @ ..] => { [first, rest @ ..] => {
// FIXME(jhpratt) Do we want to perform this check? It doesn't exist
// for `#[inline]`, `#[non_exhaustive]`, and presumably others.
let suggestion_text = let suggestion_text =
if rest.len() == 1 { "try removing this" } else { "try removing these" }; if rest.len() == 1 { "try removing this" } else { "try removing these" };