bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

First batch of review feedback changes from #102110

Browse source
This commit is contained in:
Nathan Stocks 2022-10-03 17:34:59 -06:00
parent be4059dd3e
commit 965dbf6c28
9 changed files with 43 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_passes/src/lang_items.rs
View file

@ -20,7 +20,7 @@ use rustc_hir::lang_items::{extract, GenericRequirement, ITEM_REFS};
use rustc_hir::{HirId, LangItem, LanguageItems, Target};
use rustc_middle::ty::TyCtxt;
use rustc_session::cstore::ExternCrate;
use rustc_span::{Span, Symbol};
use rustc_span::{symbol::kw::Empty, Span};
use rustc_middle::ty::query::Providers;
@ -66,7 +66,7 @@ impl<'tcx> LanguageItemCollector<'tcx> {
let local_span = self.tcx.hir().span_if_local(item_def_id);
let lang_item_name = LangItem::from_u32(item_index as u32).unwrap().name();
let crate_name = self.tcx.crate_name(item_def_id.krate);
let mut dependency_of = Symbol::intern("");
let mut dependency_of = Empty;
let is_local = item_def_id.is_local();
let path = if is_local {
String::new()
@ -80,8 +80,8 @@ impl<'tcx> LanguageItemCollector<'tcx> {
.into()
};
let first_defined_span = self.tcx.hir().span_if_local(original_def_id);
let mut orig_crate_name = Symbol::intern("");
let mut orig_dependency_of = Symbol::intern("");
let mut orig_crate_name = Empty;
let mut orig_dependency_of = Empty;
let orig_is_local = original_def_id.is_local();
let orig_path = if orig_is_local {
String::new()