bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add comment to mem::replace to explain why it's not implemented via mem::swap

Browse source
This commit is contained in:
Carter Hunt Fogelman 2023-10-26 11:10:04 -07:00
parent ccb160d343
commit 94ecabfc4e
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
library/core/src/mem/mod.rs
View file

@ -909,6 +909,10 @@ pub fn take<T: Default>(dest: &mut T) -> T {
#[rustc_const_unstable(feature = "const_replace", issue = "83164")]
#[cfg_attr(not(test), rustc_diagnostic_item = "mem_replace")]
pub const fn replace<T>(dest: &mut T, src: T) -> T {
// It may be tempting to use `swap` to avoid `unsafe` here. Don't!
// The compiler optimizes the implementation below to two `memcpy`s
// while `swap` would require at least three. See PR#83022 for details.
// SAFETY: We read from `dest` but directly write `src` into it afterwards,
// such that the old value is not duplicated. Nothing is dropped and
// nothing here can panic.