bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

cleanup: add some comments per review feedback

Browse source
This commit is contained in:
Augie Fackler 2021-03-22 14:37:49 -04:00
parent babe894bab
commit 9431e8577d
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
View file

@ -1438,6 +1438,9 @@ LLVMRustCreateThinLTOData(LLVMRustThinLTOModule *modules,
}; };
#if LLVM_VERSION_GE(13,0) #if LLVM_VERSION_GE(13,0)
// Uses FromPrevailing visibility scheme which works for many binary
// formats. We probably could and should use ELF visibility scheme for many of
// our targets, however.
lto::Config conf; lto::Config conf;
thinLTOResolvePrevailingInIndex(conf, Ret->Index, isPrevailing, recordNewLinkage, thinLTOResolvePrevailingInIndex(conf, Ret->Index, isPrevailing, recordNewLinkage,
Ret->GUIDPreservedSymbols); Ret->GUIDPreservedSymbols);

3
compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
View file

@ -383,6 +383,9 @@ LLVMRustBuildAtomicCmpXchg(LLVMBuilderRef B, LLVMValueRef Target,
LLVMAtomicOrdering Order, LLVMAtomicOrdering Order,
LLVMAtomicOrdering FailureOrder, LLVMBool Weak) { LLVMAtomicOrdering FailureOrder, LLVMBool Weak) {
#if LLVM_VERSION_GE(13,0) #if LLVM_VERSION_GE(13,0)
// Rust probably knows the alignment of the target value and should be able to
// specify something more precise than MaybeAlign here. See also
// https://reviews.llvm.org/D97224 which may be a useful reference.
AtomicCmpXchgInst *ACXI = unwrap(B)->CreateAtomicCmpXchg( AtomicCmpXchgInst *ACXI = unwrap(B)->CreateAtomicCmpXchg(
unwrap(Target), unwrap(Old), unwrap(Source), llvm::MaybeAlign(), fromRust(Order), unwrap(Target), unwrap(Old), unwrap(Source), llvm::MaybeAlign(), fromRust(Order),
fromRust(FailureOrder)); fromRust(FailureOrder));