bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

mark binding undetermined if target name exist and not obtained

Browse source
This commit is contained in:
bohan 2024-06-06 16:09:20 +08:00
parent 1be24d70ce
commit 93feaa6685
5 changed files with 49 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_resolve/src/ident.rs
View file

@ -998,14 +998,14 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
let Some(module) = single_import.imported_module.get() else {
return Err((Undetermined, Weak::No));
};
let ImportKind::Single { source: ident, source_bindings, .. } = &single_import.kind
let ImportKind::Single { source: ident, target, target_bindings, .. } =
&single_import.kind
else {
unreachable!();
};
if binding.map_or(false, |binding| binding.module().is_some())
&& source_bindings.iter().all(|binding| matches!(binding.get(), Err(Undetermined)))
{
// This branch allows the binding to be defined or updated later,
if (ident != target) && target_bindings.iter().all(|binding| binding.get().is_none()) {
// This branch allows the binding to be defined or updated later if the target name
// can hide the source but these bindings are not obtained.
// avoiding module inconsistency between the resolve process and the finalize process.
// See more details in #124840
return Err((Undetermined, Weak::No));