bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Improve the warning messages for the #[diagnostic::on_unimplemented]

Browse source 
This commit improves warnings emitted for malformed on unimplemented
attributes by:

* Improving the span of the warnings
* Adding a label message to them
* Separating the messages for missing and unexpected options
* Adding a help message that says which options are supported
This commit is contained in:
Georg Semmler 2023-10-19 08:44:15 +02:00
parent 020d00867a
commit 9017b974ee
No known key found for this signature in database
GPG key ID: A87BCEE5205CE489
5 changed files with 126 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_trait_selection/messages.ftl
View file

@ -28,6 +28,11 @@ trait_selection_invalid_on_clause_in_rustc_on_unimplemented = invalid `on`-claus
.label = invalid on-clause here
trait_selection_malformed_on_unimplemented_attr = malformed `on_unimplemented` attribute
.help = only `message`, `note` and `label` are allowed as options
.label = invalid option found here
trait_selection_missing_options_for_on_unimplemented_attr = missing options for `on_unimplemented` attribute
.help = at least one of the `message`, `note` and `label` options are expected
trait_selection_negative_positive_conflict = found both positive and negative implementation of trait `{$trait_desc}`{$self_desc ->
[none] {""}