bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #133297 - DianQK:embed-bitcode-ios, r=nikic

Browse source 
Remove legacy bitcode for iOS

Follow #117364.
This commit is contained in:
许杰友 Jieyou Xu (Joe) 2024-11-25 00:39:05 +08:00 • committed by GitHub
commit 8d20d71256
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 8 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

19
compiler/rustc_codegen_llvm/src/back/write.rs
View file

@ -955,24 +955,7 @@ pub(crate) fn bitcode_section_name(cgcx: &CodegenContext<LlvmCodegenBackend>) ->
}
}
/// Embed the bitcode of an LLVM module in the LLVM module itself.
///
/// This is done primarily for iOS where it appears to be standard to compile C
/// code at least with `-fembed-bitcode` which creates two sections in the
/// executable:
///
/// * __LLVM,__bitcode
/// * __LLVM,__cmdline
///
/// It appears *both* of these sections are necessary to get the linker to
/// recognize what's going on. A suitable cmdline value is taken from the
/// target spec.
///
/// Furthermore debug/O1 builds don't actually embed bitcode but rather just
/// embed an empty section.
///
/// Basically all of this is us attempting to follow in the footsteps of clang
/// on iOS. See #35968 for lots more info.
/// Embed the bitcode of an LLVM module for LTO in the LLVM module itself.
unsafe fn embed_bitcode(
cgcx: &CodegenContext<LlvmCodegenBackend>,
llcx: &llvm::Context,