bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Explicitly mention overflow is what we're checking

Browse source
This commit is contained in:
Michael Bradshaw 2022-03-23 08:14:53 -06:00 • committed by GitHub
parent f5dd42bce5
commit 8d14c03568
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
library/alloc/src/rc.rs
View file

@ -2524,8 +2524,8 @@ trait RcInnerPtr {
self.strong_ref().set(strong); self.strong_ref().set(strong);
// We want to abort on overflow instead of dropping the value. // We want to abort on overflow instead of dropping the value.
// Checking after the store instead of before allows for // Checking for overflow after the store instead of before
// slightly better code generation. // allows for slightly better code generation.
if core::intrinsics::unlikely(strong == 0) { if core::intrinsics::unlikely(strong == 0) {
abort(); abort();
} }
@ -2557,8 +2557,8 @@ trait RcInnerPtr {
self.weak_ref().set(weak); self.weak_ref().set(weak);
// We want to abort on overflow instead of dropping the value. // We want to abort on overflow instead of dropping the value.
// Checking after the store instead of before allows for // Checking for overflow after the store instead of before
// slightly better code generation. // allows for slightly better code generation.
if core::intrinsics::unlikely(weak == 0) { if core::intrinsics::unlikely(weak == 0) {
abort(); abort();
} }