bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Simplify rustc_hir::intravisit::Visitor::visit_variant_data.

Browse source 
It has four arguments that are never used. This avoids lots of argument
passing in functions that feed into `visit_variant_data`.
This commit is contained in:
Nicholas Nethercote 2022-08-10 11:22:01 +10:00
parent f03ce30962
commit 8c5303898e
11 changed files with 32 additions and 116 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_ast_lowering/src/index.rs
View file

@ -295,14 +295,14 @@ impl<'a, 'hir> Visitor<'hir> for NodeCollector<'a, 'hir> {
self.insert(lifetime.span, lifetime.hir_id, Node::Lifetime(lifetime));
}
fn visit_variant(&mut self, v: &'hir Variant<'hir>, g: &'hir Generics<'hir>, item_id: HirId) {
fn visit_variant(&mut self, v: &'hir Variant<'hir>) {
self.insert(v.span, v.id, Node::Variant(v));
self.with_parent(v.id, |this| {
// Register the constructor of this variant.
if let Some(ctor_hir_id) = v.data.ctor_hir_id() {
this.insert(v.span, ctor_hir_id, Node::Ctor(&v.data));
}
intravisit::walk_variant(this, v, g, item_id);
intravisit::walk_variant(this, v);
});
}