bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Always sort suggestions before emitting them

Browse source
This commit is contained in:
Esteban Kuber 2021-10-01 18:09:31 +00:00
parent ef212e7fb3
commit 881a50c0b7
10 changed files with 39 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_errors/src/diagnostic.rs
View file

@ -465,10 +465,14 @@ impl Diagnostic {
suggestions: impl Iterator<Item = String>,
applicability: Applicability,
) -> &mut Self {
let mut suggestions: Vec<_> = suggestions.collect();
suggestions.sort();
let substitutions = suggestions
.into_iter()
.map(|snippet| Substitution { parts: vec![SubstitutionPart { snippet, span: sp }] })
.collect();
self.suggestions.push(CodeSuggestion {
substitutions: suggestions
.map(|snippet| Substitution { parts: vec![SubstitutionPart { snippet, span: sp }] })
.collect(),
substitutions,
msg: msg.to_owned(),
style: SuggestionStyle::ShowCode,
applicability,