bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Suggest while let x = y when encountering while x = y

Browse source 
Extends #75931 to also detect where the `let` might be missing from `while let` expressions.
This commit is contained in:
ametisf 2021-12-29 13:23:19 +01:00
parent b70cc6422c
commit 874cd08e23
3 changed files with 56 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_resolve/src/late.rs
View file

@ -2376,7 +2376,9 @@ impl<'a: 'ast, 'b, 'ast> LateResolutionVisitor<'a, 'b, 'ast> {
ExprKind::While(ref cond, ref block, label) => {
self.with_resolved_label(label, expr.id, |this| {
this.with_rib(ValueNS, NormalRibKind, |this| {
let old = this.diagnostic_metadata.in_if_condition.replace(cond);
this.visit_expr(cond);
this.diagnostic_metadata.in_if_condition = old;
this.visit_block(block);
})
});