bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Move visit_id calls.

Browse source 
In `walk_item`, we call `visit_id` on every item kind. For most of them
we do it directly in `walk_item`. But for `ItemKind::Mod`,
`ItemKind::Enum`, and `ItemKind::Use` we instead do it in the `walk_*`
function called (via the `visit_*` function) from `walk_item`.

I can see no reason for this inconsistency, so this commit makes those
three cases like all the other cases, moving the `visit_id` calls into
`walk_item`. This also avoids the need for a few `HirId` arguments.
This commit is contained in:
Nicholas Nethercote 2025-03-07 17:02:33 +11:00
parent 98a48781fe
commit 872ac73f59
5 changed files with 14 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_middle/src/hir/map.rs
View file

@ -1356,7 +1356,7 @@ impl<'hir> Visitor<'hir> for ItemCollector<'hir> {
self.submodules.push(item.owner_id);
// A module collector does not recurse inside nested modules.
if self.crate_collector {
intravisit::walk_mod(self, module, item.hir_id());
intravisit::walk_mod(self, module);
}
} else {
intravisit::walk_item(self, item)