bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #134284 - estebank:issue-74863, r=lcnr

Browse source 
Keep track of patterns that could have introduced a binding, but didn't

When we recover from a pattern parse error, or a pattern uses `..`, we keep track of that and affect resolution error for missing bindings that could have been provided by that pattern. We differentiate between `..` and parse recovery. We silence resolution errors likely caused by the pattern parse error.

```
error[E0425]: cannot find value `title` in this scope
  --> $DIR/struct-pattern-with-missing-fields-resolve-error.rs:18:30
   |
LL |     if let Website { url, .. } = website {
   |            ------------------- this pattern doesn't include `title`, which is available in `Website`
LL |         println!("[{}]({})", title, url);
   |                              ^^^^^ not found in this scope
```

Fix #74863.
This commit is contained in:
Matthias Krüger 2024-12-16 20:00:22 +01:00 • committed by GitHub
commit 86db97e2b3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 135 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_ast_pretty/src/pprust/state.rs
View file

@ -1654,11 +1654,14 @@ impl<'a> State<'a> {
},
|f| f.pat.span,
);
if *etc == ast::PatFieldsRest::Rest {
if let ast::PatFieldsRest::Rest | ast::PatFieldsRest::Recovered(_) = etc {
if !fields.is_empty() {
self.word_space(",");
}
self.word("..");
if let ast::PatFieldsRest::Recovered(_) = etc {
self.word("/* recovered parse error */");
}
}
if !empty {
self.space();