Rollup merge of #138270 - StevenMia:master, r=compiler-errors
chore: Fix some comments Fix some comments
This commit is contained in:
commit
86065acbc3
5 changed files with 6 additions and 6 deletions
|
@ -610,7 +610,7 @@ impl<'tcx> LivenessContext<'_, '_, '_, 'tcx> {
|
||||||
Err(ErrorGuaranteed { .. }) => {
|
Err(ErrorGuaranteed { .. }) => {
|
||||||
// We don't run dropck on HIR, and dropck looks inside fields of
|
// We don't run dropck on HIR, and dropck looks inside fields of
|
||||||
// types, so there's no guarantee that it succeeds. We also
|
// types, so there's no guarantee that it succeeds. We also
|
||||||
// can't rely on the the `ErrorGuaranteed` from `fully_perform` here
|
// can't rely on the `ErrorGuaranteed` from `fully_perform` here
|
||||||
// because it comes from delay_span_bug.
|
// because it comes from delay_span_bug.
|
||||||
//
|
//
|
||||||
// Do this inside of a probe because we don't particularly care (or want)
|
// Do this inside of a probe because we don't particularly care (or want)
|
||||||
|
|
|
@ -363,7 +363,7 @@ pub trait Visitor<'v>: Sized {
|
||||||
/// See the doc comments on [`Ty`] for an explanation of what it means for a type to be
|
/// See the doc comments on [`Ty`] for an explanation of what it means for a type to be
|
||||||
/// ambiguous.
|
/// ambiguous.
|
||||||
///
|
///
|
||||||
/// The [`Visitor::visit_infer`] method should be overriden in order to handle infer vars.
|
/// The [`Visitor::visit_infer`] method should be overridden in order to handle infer vars.
|
||||||
fn visit_ty(&mut self, t: &'v Ty<'v, AmbigArg>) -> Self::Result {
|
fn visit_ty(&mut self, t: &'v Ty<'v, AmbigArg>) -> Self::Result {
|
||||||
walk_ty(self, t)
|
walk_ty(self, t)
|
||||||
}
|
}
|
||||||
|
@ -374,7 +374,7 @@ pub trait Visitor<'v>: Sized {
|
||||||
/// See the doc comments on [`ConstArg`] for an explanation of what it means for a const to be
|
/// See the doc comments on [`ConstArg`] for an explanation of what it means for a const to be
|
||||||
/// ambiguous.
|
/// ambiguous.
|
||||||
///
|
///
|
||||||
/// The [`Visitor::visit_infer`] method should be overriden in order to handle infer vars.
|
/// The [`Visitor::visit_infer`] method should be overridden in order to handle infer vars.
|
||||||
fn visit_const_arg(&mut self, c: &'v ConstArg<'v, AmbigArg>) -> Self::Result {
|
fn visit_const_arg(&mut self, c: &'v ConstArg<'v, AmbigArg>) -> Self::Result {
|
||||||
walk_ambig_const_arg(self, c)
|
walk_ambig_const_arg(self, c)
|
||||||
}
|
}
|
||||||
|
|
|
@ -133,7 +133,7 @@ impl<'tcx> LateLintPass<'tcx> for DefaultCouldBeDerived {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// At least one of the fields with a default value have been overriden in
|
// At least one of the fields with a default value have been overridden in
|
||||||
// the `Default` implementation. We suggest removing it and relying on `..`
|
// the `Default` implementation. We suggest removing it and relying on `..`
|
||||||
// instead.
|
// instead.
|
||||||
let any_default_field_given =
|
let any_default_field_given =
|
||||||
|
|
|
@ -67,7 +67,7 @@ have default field values.
|
||||||
## Lints
|
## Lints
|
||||||
|
|
||||||
When manually implementing the `Default` trait for a type that has default
|
When manually implementing the `Default` trait for a type that has default
|
||||||
field values, if any of these are overriden in the impl the
|
field values, if any of these are overridden in the impl the
|
||||||
`default_overrides_default_fields` lint will trigger. This lint is in place
|
`default_overrides_default_fields` lint will trigger. This lint is in place
|
||||||
to avoid surprising diverging behavior between `S { .. }` and
|
to avoid surprising diverging behavior between `S { .. }` and
|
||||||
`S::default()`, where using the same type in both ways could result in
|
`S::default()`, where using the same type in both ways could result in
|
||||||
|
|
|
@ -3,7 +3,7 @@
|
||||||
//
|
//
|
||||||
// It should work, but due to interactions between how #[cfg]s are
|
// It should work, but due to interactions between how #[cfg]s are
|
||||||
// expanded, the lint machinery and the check-cfg impl, we
|
// expanded, the lint machinery and the check-cfg impl, we
|
||||||
// miss the #[allow], althrough we probably shoudln't.
|
// miss the #[allow], althrough we probably shouldn't.
|
||||||
//
|
//
|
||||||
// cf. https://github.com/rust-lang/rust/issues/124735
|
// cf. https://github.com/rust-lang/rust/issues/124735
|
||||||
//
|
//
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue