bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Only show notable traits if both types are the same

Browse source 
Checking only their DefId doesn't work because all slices have the same
fake DefId.

Fixes #91347
This commit is contained in:
Michael Howell 2021-11-29 12:18:57 -07:00
parent 6db0a0e9a4
commit 85ba6c7b34
3 changed files with 67 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/librustdoc/html/render/mod.rs
View file

@ -1235,10 +1235,17 @@ fn should_render_item(item: &clean::Item, deref_mut_: bool, tcx: TyCtxt<'_>) ->
fn notable_traits_decl(decl: &clean::FnDecl, cx: &Context<'_>) -> String {
let mut out = Buffer::html();
if let Some(did) = decl.output.as_return().and_then(|t| t.def_id(cx.cache())) {
if let Some((did, ty)) = decl.output.as_return().and_then(|t| Some((t.def_id(cx.cache())?, t)))
{
if let Some(impls) = cx.cache().impls.get(&did) {
for i in impls {
let impl_ = i.inner_impl();
if !impl_.for_.without_borrowed_ref().is_same(ty.without_borrowed_ref(), cx.cache())
{
// Two different types might have the same did,
// without actually being the same.
continue;
}
if let Some(trait_) = &impl_.trait_ {
let trait_did = trait_.def_id();