bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #99718 - TaKO8Ki:avoid-&str-symbol-to-string-conversions, r=michaelwoerister

Browse source 
Avoid `&str`/`Symbol` to `String` conversions

follow-up to #99342 and #98668
This commit is contained in:
Yuki Okushi 2022-07-26 13:12:23 +09:00 • committed by GitHub
commit 85afb90788
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 19 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

11
compiler/rustc_span/src/source_map.rs
View file

@ -586,17 +586,6 @@ impl SourceMap {
}
}
/// Returns whether or not this span points into a file
/// in the current crate. This may be `false` for spans
/// produced by a macro expansion, or for spans associated
/// with the definition of an item in a foreign crate
pub fn is_local_span(&self, sp: Span) -> bool {
let local_begin = self.lookup_byte_offset(sp.lo());
let local_end = self.lookup_byte_offset(sp.hi());
// This might be a weird span that covers multiple files
local_begin.sf.src.is_some() && local_end.sf.src.is_some()
}
pub fn is_span_accessible(&self, sp: Span) -> bool {
self.span_to_source(sp, |src, start_index, end_index| {
Ok(src.get(start_index..end_index).is_some())