bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

get rid of some tidy 'unnecessarily ignored' warnings

Browse source
This commit is contained in:
Ralf Jung 2022-06-30 11:23:51 -04:00
parent 7425fb293f
commit 8515475ffd
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/tools/tidy/src/style.rs
View file

@ -395,9 +395,6 @@ pub fn check(path: &Path, bad: &mut bool) {
); );
}; };
suppressible_tidy_err!(err, skip_file_length, ""); suppressible_tidy_err!(err, skip_file_length, "");
} else if lines > (LINES * 7) / 10 {
// Just set it to something that doesn't trigger the "unnecessarily ignored" warning.
skip_file_length = Directive::Ignore(true);
} }
if let Directive::Ignore(false) = skip_cr { if let Directive::Ignore(false) = skip_cr {
@ -406,12 +403,6 @@ pub fn check(path: &Path, bad: &mut bool) {
if let Directive::Ignore(false) = skip_tab { if let Directive::Ignore(false) = skip_tab {
tidy_error!(bad, "{}: ignoring tab characters unnecessarily", file.display()); tidy_error!(bad, "{}: ignoring tab characters unnecessarily", file.display());
} }
if let Directive::Ignore(false) = skip_line_length {
tidy_error!(bad, "{}: ignoring line length unnecessarily", file.display());
}
if let Directive::Ignore(false) = skip_file_length {
tidy_error!(bad, "{}: ignoring file length unnecessarily", file.display());
}
if let Directive::Ignore(false) = skip_end_whitespace { if let Directive::Ignore(false) = skip_end_whitespace {
tidy_error!(bad, "{}: ignoring trailing whitespace unnecessarily", file.display()); tidy_error!(bad, "{}: ignoring trailing whitespace unnecessarily", file.display());
} }
@ -424,5 +415,9 @@ pub fn check(path: &Path, bad: &mut bool) {
if let Directive::Ignore(false) = skip_copyright { if let Directive::Ignore(false) = skip_copyright {
tidy_error!(bad, "{}: ignoring copyright unnecessarily", file.display()); tidy_error!(bad, "{}: ignoring copyright unnecessarily", file.display());
} }
// We deliberately do not warn about these being unnecessary,
// that would just lead to annoying churn.
let _unused = skip_line_length;
let _unused = skip_file_length;
}) })
} }