bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Don't add attribute to allow unused-qualifications to derive impl's

Browse source 
Currently `#![forbid(unused_qualifications)]` is incompatible with all
derive's because we add `#[allow(unused_qualifications)]` in all
generated impl's.
This commit is contained in:
Samrat Man Singh 2020-05-07 10:53:44 +05:30 • committed by Michael Holloway
parent ed9173276a
commit 8374ab6d65
3 changed files with 39 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_builtin_macros/src/deriving/generic/mod.rs
View file

@ -727,16 +727,8 @@ impl<'a> TraitDef<'a> {
let attr = cx.attribute(cx.meta_word(self.span, sym::automatically_derived));
let opt_trait_ref = Some(trait_ref);
let unused_qual = {
let word = rustc_ast::attr::mk_nested_word_item(Ident::new(
sym::unused_qualifications,
self.span,
));
let list = rustc_ast::attr::mk_list_item(Ident::new(sym::allow, self.span), vec![word]);
cx.attribute(list)
};
let mut a = vec![attr, unused_qual];
let mut a = vec![attr];
a.extend(self.attributes.iter().cloned());
cx.item(