bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Extract mir_opt_level to a method and use Option to be able to know if the value is provided or not

Browse source
This commit is contained in:
Santiago Pastorino 2021-03-03 18:19:15 -03:00
parent 409920873c
commit 8152da22a1
No known key found for this signature in database
GPG key ID: 8131A24E0C79EFAF
14 changed files with 34 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

30
compiler/rustc_session/src/config.rs
View file

@ -1938,21 +1938,23 @@ pub fn build_session_options(matches: &getopts::Matches) -> Options {
Some(SymbolManglingVersion::V0) => {}
}
if debugging_opts.mir_opt_level > 1 {
// Functions inlined during MIR transform can, at best, make it impossible to
// effectively cover inlined functions, and, at worst, break coverage map generation
// during LLVM codegen. For example, function counter IDs are only unique within a
// function. Inlining after these counters are injected can produce duplicate counters,
// resulting in an invalid coverage map (and ICE); so this option combination is not
// allowed.
early_warn(
error_format,
&format!(
"`-Z mir-opt-level={}` (or any level > 1) enables function inlining, which \
if let Some(mir_opt_level) = debugging_opts.mir_opt_level {
if mir_opt_level > 1 {
// Functions inlined during MIR transform can, at best, make it impossible to
// effectively cover inlined functions, and, at worst, break coverage map generation
// during LLVM codegen. For example, function counter IDs are only unique within a
// function. Inlining after these counters are injected can produce duplicate counters,
// resulting in an invalid coverage map (and ICE); so this option combination is not
// allowed.
early_warn(
error_format,
&format!(
"`-Z mir-opt-level={}` (or any level > 1) enables function inlining, which \
is incompatible with `-Z instrument-coverage`. Inlining will be disabled.",
debugging_opts.mir_opt_level,
),
);
mir_opt_level,
),
);
}
}
}