bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

add bunch of fixmes: currently there exist some functions that accept LLVMValueRef, some that accept LLVMMetadataRef, and replacing one with another not always possible without explicit convertion

Browse source
This commit is contained in:
klensy 2023-04-02 17:11:41 +03:00
parent 0b5f9ac73e
commit 7d6181e4d8
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_codegen_llvm/src/llvm/ffi.rs
View file

@ -1072,7 +1072,13 @@ extern "C" {
pub fn LLVMGetPoison(Ty: &Type) -> &Value; pub fn LLVMGetPoison(Ty: &Type) -> &Value;
// Operations on metadata // Operations on metadata
// FIXME: deprecated, replace with LLVMMDStringInContext2
pub fn LLVMMDStringInContext(C: &Context, Str: *const c_char, SLen: c_uint) -> &Value; pub fn LLVMMDStringInContext(C: &Context, Str: *const c_char, SLen: c_uint) -> &Value;
// LLVMMDStringInContext but don't own string
pub fn LLVMMDStringInContext2(C: &Context, Str: *const c_char, SLen: size_t) -> &Metadata;
// FIXME: deprecated, replace with LLVMMDNodeInContext2
pub fn LLVMMDNodeInContext<'a>( pub fn LLVMMDNodeInContext<'a>(
C: &'a Context, C: &'a Context,
Vals: *const &'a Value, Vals: *const &'a Value,
@ -1111,6 +1117,8 @@ extern "C" {
Packed: Bool, Packed: Bool,
) -> &'a Value; ) -> &'a Value;
// FIXME: replace with LLVMConstArray2
// https://github.com/llvm/llvm-project/commit/35276f16e5a2cae0dfb49c0fbf874d4d2f177acc
pub fn LLVMConstArray<'a>( pub fn LLVMConstArray<'a>(
ElementTy: &'a Type, ElementTy: &'a Type,
ConstantVals: *const &'a Value, ConstantVals: *const &'a Value,

2
compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
View file

@ -1150,6 +1150,8 @@ extern "C" void LLVMRustWriteValueToString(LLVMValueRef V,
} }
// LLVMArrayType function does not support 64-bit ElementCount // LLVMArrayType function does not support 64-bit ElementCount
// FIXME: replace with LLVMArrayType2
// https://github.com/llvm/llvm-project/commit/35276f16e5a2cae0dfb49c0fbf874d4d2f177acc
extern "C" LLVMTypeRef LLVMRustArrayType(LLVMTypeRef ElementTy, extern "C" LLVMTypeRef LLVMRustArrayType(LLVMTypeRef ElementTy,
uint64_t ElementCount) { uint64_t ElementCount) {
return wrap(ArrayType::get(unwrap(ElementTy), ElementCount)); return wrap(ArrayType::get(unwrap(ElementTy), ElementCount));