Auto merge of #87265 - Aaron1011:hir-wf-fn, r=estebank
Support HIR wf checking for function signatures During function type-checking, we normalize any associated types in the function signature (argument types + return type), and then create WF obligations for each of the normalized types. The HIR wf code does not currently support this case, so any errors that we get have imprecise spans. This commit extends `ObligationCauseCode::WellFormed` to support recording a function parameter, allowing us to get the corresponding HIR type if an error occurs. Function typechecking is modified to pass this information during signature normalization and WF checking. The resulting code is fairly verbose, due to the fact that we can no longer normalize the entire signature with a single function call. As part of the refactoring, we now perform HIR-based WF checking for several other 'typed items' (statics, consts, and inherent impls). As a result, WF and projection errors in a function signature now have a precise span, which points directly at the responsible type. If a function signature is constructed via a macro, this will allow the error message to point at the code 'most responsible' for the error (e.g. a user-supplied macro argument).
This commit is contained in:
commit
7c89e389d0
28 changed files with 240 additions and 91 deletions
|
@ -242,11 +242,11 @@ impl<'a, 'tcx> InferCtxtExt<'tcx> for InferCtxt<'a, 'tcx> {
|
|||
SelectionError::Unimplemented => {
|
||||
// If this obligation was generated as a result of well-formed checking, see if we
|
||||
// can get a better error message by performing HIR-based well formed checking.
|
||||
if let ObligationCauseCode::WellFormed(Some(wf_hir_id)) =
|
||||
if let ObligationCauseCode::WellFormed(Some(wf_loc)) =
|
||||
root_obligation.cause.code.peel_derives()
|
||||
{
|
||||
if let Some(cause) =
|
||||
self.tcx.diagnostic_hir_wf_check((obligation.predicate, *wf_hir_id))
|
||||
self.tcx.diagnostic_hir_wf_check((obligation.predicate, wf_loc.clone()))
|
||||
{
|
||||
obligation.cause = cause;
|
||||
span = obligation.cause.span;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue