bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #89090 - cjgillot:bare-dyn, r=jackh726

Browse source 
Lint bare traits in AstConv.

Removing the lint from lowering allows to:
- make lowering querification easier;
- have the lint implementation in only one place.

r? `@estebank`
This commit is contained in:
Matthias Krüger 2021-12-18 08:16:26 +01:00 • committed by GitHub
commit 7a626cf7ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
51 changed files with 731 additions and 320 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_lint/src/context.rs
View file

@ -633,16 +633,6 @@ pub trait LintContext: Sized {
}
},
BuiltinLintDiagnostics::Normal => (),
BuiltinLintDiagnostics::BareTraitObject(span, is_global) => {
let (sugg, app) = match sess.source_map().span_to_snippet(span) {
Ok(s) if is_global => {
(format!("dyn ({})", s), Applicability::MachineApplicable)
}
Ok(s) => (format!("dyn {}", s), Applicability::MachineApplicable),
Err(_) => ("dyn <type>".to_string(), Applicability::HasPlaceholders),
};
db.span_suggestion(span, "use `dyn`", sugg, app);
}
BuiltinLintDiagnostics::AbsPathWithModule(span) => {
let (sugg, app) = match sess.source_map().span_to_snippet(span) {
Ok(ref s) => {