bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #98783 - RalfJung:jumpscares, r=fee1-dead

Browse source 
interpret: make a comment less scary

This slipped past my review: "has no meaning" could be read as "is undefined behavior". That is certainly not what we mean so be more clear.
This commit is contained in:
Dylan DPC 2022-07-02 12:23:42 +05:30 • committed by GitHub
commit 7a4f33bec9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_const_eval/src/interpret/cast.rs
View file

@ -202,7 +202,7 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
let ptr = self.scalar_to_ptr(scalar)?; let ptr = self.scalar_to_ptr(scalar)?;
match ptr.into_pointer_or_addr() { match ptr.into_pointer_or_addr() {
Ok(ptr) => M::expose_ptr(self, ptr)?, Ok(ptr) => M::expose_ptr(self, ptr)?,
Err(_) => {} // do nothing, exposing an invalid pointer has no meaning Err(_) => {} // Do nothing, exposing an invalid pointer (`None` provenance) is a NOP.
}; };
Ok(self.cast_from_int_like(scalar, src.layout, cast_ty)?.into()) Ok(self.cast_from_int_like(scalar, src.layout, cast_ty)?.into())
} }