rollup merge of #17729 : alexcrichton/issue-17718-start
This commit is contained in:
commit
79d0e82f73
3 changed files with 44 additions and 5 deletions
|
@ -4732,8 +4732,7 @@ impl<'a> Parser<'a> {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn parse_item_const(&mut self) -> ItemInfo {
|
fn parse_item_const(&mut self, m: Mutability) -> ItemInfo {
|
||||||
let m = if self.eat_keyword(keywords::Mut) {MutMutable} else {MutImmutable};
|
|
||||||
let id = self.parse_ident();
|
let id = self.parse_ident();
|
||||||
self.expect(&token::COLON);
|
self.expect(&token::COLON);
|
||||||
let ty = self.parse_ty(true);
|
let ty = self.parse_ty(true);
|
||||||
|
@ -5289,7 +5288,26 @@ impl<'a> Parser<'a> {
|
||||||
if self.is_keyword(keywords::Static) {
|
if self.is_keyword(keywords::Static) {
|
||||||
// STATIC ITEM
|
// STATIC ITEM
|
||||||
self.bump();
|
self.bump();
|
||||||
let (ident, item_, extra_attrs) = self.parse_item_const();
|
let m = if self.eat_keyword(keywords::Mut) {MutMutable} else {MutImmutable};
|
||||||
|
let (ident, item_, extra_attrs) = self.parse_item_const(m);
|
||||||
|
let last_span = self.last_span;
|
||||||
|
let item = self.mk_item(lo,
|
||||||
|
last_span.hi,
|
||||||
|
ident,
|
||||||
|
item_,
|
||||||
|
visibility,
|
||||||
|
maybe_append(attrs, extra_attrs));
|
||||||
|
return IoviItem(item);
|
||||||
|
}
|
||||||
|
if self.is_keyword(keywords::Const) {
|
||||||
|
// CONST ITEM
|
||||||
|
self.bump();
|
||||||
|
if self.eat_keyword(keywords::Mut) {
|
||||||
|
let last_span = self.last_span;
|
||||||
|
self.span_err(last_span, "const globals cannot be mutable, \
|
||||||
|
did you mean to declare a static?");
|
||||||
|
}
|
||||||
|
let (ident, item_, extra_attrs) = self.parse_item_const(MutImmutable);
|
||||||
let last_span = self.last_span;
|
let last_span = self.last_span;
|
||||||
let item = self.mk_item(lo,
|
let item = self.mk_item(lo,
|
||||||
last_span.hi,
|
last_span.hi,
|
||||||
|
|
17
src/test/compile-fail/issue-17718-const-mut.rs
Normal file
17
src/test/compile-fail/issue-17718-const-mut.rs
Normal file
|
@ -0,0 +1,17 @@
|
||||||
|
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
||||||
|
// file at the top-level directory of this distribution and at
|
||||||
|
// http://rust-lang.org/COPYRIGHT.
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||||
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||||
|
// option. This file may not be copied, modified, or distributed
|
||||||
|
// except according to those terms.
|
||||||
|
|
||||||
|
const
|
||||||
|
mut //~ ERROR: const globals cannot be mutable, did you mean to declare a static?
|
||||||
|
FOO: uint = 3;
|
||||||
|
|
||||||
|
fn main() {
|
||||||
|
}
|
||||||
|
|
|
@ -1,4 +1,4 @@
|
||||||
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
|
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
||||||
// file at the top-level directory of this distribution and at
|
// file at the top-level directory of this distribution and at
|
||||||
// http://rust-lang.org/COPYRIGHT.
|
// http://rust-lang.org/COPYRIGHT.
|
||||||
//
|
//
|
||||||
|
@ -8,4 +8,8 @@
|
||||||
// option. This file may not be copied, modified, or distributed
|
// option. This file may not be copied, modified, or distributed
|
||||||
// except according to those terms.
|
// except according to those terms.
|
||||||
|
|
||||||
const i: int = 42; //~ ERROR expected item, found `const`
|
const FOO: uint = 3;
|
||||||
|
|
||||||
|
fn main() {
|
||||||
|
assert_eq!(FOO, 3);
|
||||||
|
}
|
Loading…
Add table
Add a link
Reference in a new issue