bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

changes based on review

Browse source
This commit is contained in:
Aliénore Bouttefeux 2021-04-09 16:13:04 +02:00
parent 0531ed0b62
commit 79666c8857
3 changed files with 34 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_lint/src/builtin.rs
View file

@ -2972,10 +2972,10 @@ declare_lint! {
///
/// ```rust,no_run
/// # #![allow(unused)]
/// use std::ptr;
/// unsafe {
/// let x = &*core::ptr::null::<i32>();
/// let x = core::ptr::addr_of!(*std::ptr::null::<i32>());
/// let x = *core::ptr::null::<i32>();
/// let x = &*ptr::null::<i32>();
/// let x = ptr::addr_of!(*ptr::null::<i32>());
/// let x = *(0 as *const i32);
/// }
/// ```
@ -3036,9 +3036,7 @@ impl<'tcx> LateLintPass<'tcx> for DerefNullPtr {
if let rustc_hir::UnOp::Deref = un_op {
if is_null_ptr(cx, expr_deref) {
cx.struct_span_lint(DEREF_NULLPTR, expr.span, |lint| {
let mut err =
lint.build("Dereferencing a null pointer causes undefined behavior");
err.span_label(expr.span, "a null pointer is dereferenced");
let mut err = lint.build("dereferencing a null pointer");
err.span_label(
expr.span,
"this code causes undefined behavior when executed",