bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

refactor: remove need for MethodCall matching

Browse source
This commit is contained in:
Max Baumann 2022-03-21 00:04:37 +01:00
parent 4580c8a9b7
commit 765cce11b1
No known key found for this signature in database
GPG key ID: 20FA1609B03B1D6D
1 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
clippy_lints/src/methods/or_then_unwrap.rs
View file

@ -39,13 +39,6 @@ pub(super) fn check<'tcx>(
return; return;
} }
let unwrap_span = if let ExprKind::MethodCall(_, _, span) = unwrap_expr.kind {
span
} else {
// unreachable. but fallback to ident's span ("()" are missing)
unwrap_expr.span
};
let mut applicability = Applicability::MachineApplicable; let mut applicability = Applicability::MachineApplicable;
let suggestion = format!( let suggestion = format!(
"unwrap_or({})", "unwrap_or({})",
@ -55,7 +48,7 @@ pub(super) fn check<'tcx>(
span_lint_and_sugg( span_lint_and_sugg(
cx, cx,
OR_THEN_UNWRAP, OR_THEN_UNWRAP,
or_span.to(unwrap_span), unwrap_expr.span.with_lo(or_span.lo()),
title, title,
"try this", "try this",
suggestion, suggestion,