bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Fix 2 variable binding issues in let_underscore

Browse source
This commit is contained in:
yukang 2024-01-08 01:15:02 +08:00
parent f688dd684f
commit 75df38e816
7 changed files with 110 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_lint/src/lints.rs
View file

@ -950,6 +950,7 @@ pub struct NonBindingLetSub {
pub suggestion: Span,
pub multi_suggestion_start: Span,
pub multi_suggestion_end: Span,
pub is_assign_desugar: bool,
}
impl AddToDiagnostic for NonBindingLetSub {
@ -960,10 +961,11 @@ impl AddToDiagnostic for NonBindingLetSub {
rustc_errors::SubdiagnosticMessage,
) -> rustc_errors::SubdiagnosticMessage,
{
let prefix = if self.is_assign_desugar { "let " } else { "" };
diag.span_suggestion_verbose(
self.suggestion,
fluent::lint_non_binding_let_suggestion,
"_unused",
format!("{prefix}_unused"),
Applicability::MachineApplicable,
);
diag.multipart_suggestion(