1
Fork 0

Fix problem noticed in PR106859 with char -> u8 suggestion

This commit is contained in:
Nick Lamb 2023-02-05 23:37:47 +00:00
parent 319b88c463
commit 747cdc0dfd
3 changed files with 57 additions and 3 deletions

View file

@ -1922,7 +1922,8 @@ impl<'tcx> TypeErrCtxt<'_, 'tcx> {
(ty::Uint(ty::UintTy::U8), ty::Char) => {
if let Ok(code) = self.tcx.sess().source_map().span_to_snippet(span)
&& let Some(code) = code.strip_prefix('\'').and_then(|s| s.strip_suffix('\''))
&& code.chars().next().map_or(false, |c| c.is_ascii())
&& !code.starts_with("\\u") // forbid all Unicode escapes
&& code.chars().next().map_or(false, |c| c.is_ascii()) // forbids literal Unicode characters beyond ASCII
{
err.span_suggestion(
span,