std: Respect formatting flags for str-like OsStr
Historically many `Display` and `Debug` implementations for `OsStr`-like abstractions have gone through `String::from_utf8_lossy`, but this was updated in #42613 to use an internal `Utf8Lossy` abstraction instead. This had the unfortunate side effect of causing a regression (#43765) in code which relied on these `fmt` trait implementations respecting the various formatting flags specified. This commit opportunistically adds back interpretation of formatting trait flags in the "common case" where where `OsStr`-like "thing" is all valid utf-8 and can delegate to the formatting implementation for `str`. This doesn't entirely solve the regression as non-utf8 paths will format differently than they did before still (in that they will not respect formatting flags), but this should solve the regression for all "real world" use cases of paths and such. The door's also still open for handling these flags in the future! Closes #43765
This commit is contained in:
parent
f3cf206201
commit
742ca0caf2
4 changed files with 29 additions and 6 deletions
|
@ -3953,4 +3953,10 @@ mod tests {
|
|||
assert_eq!(path, path_buf);
|
||||
assert!(path_buf.into_os_string().capacity() >= 15);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn display_format_flags() {
|
||||
assert_eq!(format!("a{:#<5}b", Path::new("").display()), "a#####b");
|
||||
assert_eq!(format!("a{:#<5}b", Path::new("a").display()), "aa####b");
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue