bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Optimization: process buckets only once

Browse source
This commit is contained in:
Mark Rousskov 2021-05-09 14:05:32 -04:00
parent c82fe0efb4
commit 7379d24ebc
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
compiler/rustc_data_structures/src/graph/dominators/mod.rs
View file

@ -72,6 +72,14 @@ fn dominators_given_rpo<G: ControlFlowGraph>(graph: G, rpo: &[G::Node]) -> Domin
let mut lastlinked = None;
for &w in pre_order_nodes[1..].iter().rev() {
// Optimization: process buckets just once. We need not explicitly empty
// the bucket here, but mem::take is pretty cheap.
let z = parent[w].unwrap();
for v in std::mem::take(&mut bucket[z]) {
let y = eval(&pre_order_index, &mut parent, lastlinked, &semi, &mut label, v);
idom[v] = if pre_order_index[semi[y]] < pre_order_index[z] { y } else { z };
}
semi[w] = w;
for v in graph.predecessors(w) {
let x = eval(&pre_order_index, &mut parent, lastlinked, &semi, &mut label, v);
@ -85,13 +93,6 @@ fn dominators_given_rpo<G: ControlFlowGraph>(graph: G, rpo: &[G::Node]) -> Domin
bucket[semi[w]].push(w);
link(&mut ancestor, &parent, w);
let z = parent[w].unwrap();
for v in std::mem::take(&mut bucket[z]) {
let y = eval(&pre_order_index, &mut ancestor, &semi, &mut label, v);
idom[v] = if pre_order_index[semi[y]] < pre_order_index[z] { y } else { z };
}
// Optimization: We share the parent array between processed and not
// processed elements; lastlinked represents the divider.
lastlinked = Some(w);