bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #77324 - Aaron1011:fix/const-item-mutation-ptr, r=petrochenkov

Browse source 
Don't fire `const_item_mutation` lint on writes through a pointer

Fixes #77321
This commit is contained in:
Dylan DPC 2020-10-01 02:13:43 +02:00 • committed by GitHub
commit 73258f87ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 44 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

14
compiler/rustc_mir/src/transform/check_const_item_mutation.rs
View file

@ -60,11 +60,15 @@ impl<'a, 'tcx> Visitor<'tcx> for ConstMutationChecker<'a, 'tcx> {
// so emitting a lint would be redundant.
if !lhs.projection.is_empty() {
if let Some(def_id) = self.is_const_item(lhs.local) {
self.lint_const_item_usage(def_id, loc, |lint| {
let mut lint = lint.build("attempting to modify a `const` item");
lint.note("each usage of a `const` item creates a new temporary - the original `const` item will not be modified");
lint
})
// Don't lint on writes through a pointer
// (e.g. `unsafe { *FOO = 0; *BAR.field = 1; }`)
if !matches!(lhs.projection.last(), Some(PlaceElem::Deref)) {
self.lint_const_item_usage(def_id, loc, |lint| {
let mut lint = lint.build("attempting to modify a `const` item");
lint.note("each usage of a `const` item creates a new temporary - the original `const` item will not be modified");
lint
})
}
}
}
// We are looking for MIR of the form: