bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

validate allow_internal_unstable target

Browse source 
Adds a check to make sure `#[allow_internal_unstable]`
can be applied only to macro definitions.
This commit is contained in:
Florian Warzecha 2020-10-21 22:49:08 +02:00
parent 05f4a9a42a
commit 7258740509
No known key found for this signature in database
GPG key ID: 4BE8C7D97F910C60
3 changed files with 40 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

29
compiler/rustc_passes/src/check_attr.rs
View file

@ -85,6 +85,8 @@ impl CheckAttrVisitor<'tcx> {
self.check_export_name(&attr, span, target)
} else if self.tcx.sess.check_name(attr, sym::rustc_args_required_const) {
self.check_rustc_args_required_const(&attr, span, target, item)
} else if self.tcx.sess.check_name(attr, sym::allow_internal_unstable) {
self.check_allow_internal_unstable(&attr, span, target, &attrs)
} else {
// lint-only checks
if self.tcx.sess.check_name(attr, sym::cold) {
@ -762,6 +764,33 @@ impl CheckAttrVisitor<'tcx> {
}
}
}
/// Outputs an error for `#[allow_internal_unstable]` which can only be applied to macros.
/// (Allows proc_macro functions)
fn check_allow_internal_unstable(
&self,
attr: &Attribute,
span: &Span,
target: Target,
attrs: &[Attribute],
) -> bool {
debug!("Checking target: {:?}", target);
if target == Target::Fn {
for attr in attrs {
if self.tcx.sess.is_proc_macro_attr(attr) {
debug!("Is proc macro attr");
return true;
}
}
debug!("Is not proc macro attr");
}
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to a macro")
.span_label(*span, "not a macro")
.emit();
false
}
}
impl Visitor<'tcx> for CheckAttrVisitor<'tcx> {