bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

run-make-support: remove env_var

Browse source 
This is incorrectly named (it's actually `env_clear`), and is itself
a gigantic footgun: removing `TMPDIR` on Unix and `TMP`/`TEMP` on
Windows basically wrecks anything that relies on `std::env::temp_dir`
from functioning correctly. For example, this includes rustc's codegen.
This commit is contained in:
许杰友 Jieyou Xu (Joe) 2024-06-09 14:13:38 +00:00
parent aec67e238d
commit 7255c2825d
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/tools/run-make-support/src/lib.rs
View file

@ -364,12 +364,6 @@ macro_rules! impl_common_helpers {
self self
} }
/// Clear all environmental variables.
pub fn env_var(&mut self) -> &mut Self {
self.cmd.env_clear();
self
}
/// Generic command argument provider. Prefer specific helper methods if possible. /// Generic command argument provider. Prefer specific helper methods if possible.
/// Note that for some executables, arguments might be platform specific. For C/C++ /// Note that for some executables, arguments might be platform specific. For C/C++
/// compilers, arguments might be platform *and* compiler specific. /// compilers, arguments might be platform *and* compiler specific.