bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Amortize growing rev_locals.

Browse source
This commit is contained in:
Camille GILLOT 2024-06-26 09:44:03 +00:00
parent 95986dd279
commit 70ee6e4b23
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_mir_transform/src/gvn.rs
View file

@ -293,9 +293,15 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
let (index, new) = self.values.insert_full(value); let (index, new) = self.values.insert_full(value);
let index = VnIndex::from_usize(index); let index = VnIndex::from_usize(index);
if new { if new {
// Grow `evaluated` and `rev_locals` here to amortize the allocations.
let evaluated = self.eval_to_const(index); let evaluated = self.eval_to_const(index);
let _index = self.evaluated.push(evaluated); let _index = self.evaluated.push(evaluated);
debug_assert_eq!(index, _index); debug_assert_eq!(index, _index);
// No need to push to `rev_locals` if we finished listing assignments.
if self.next_opaque.is_some() {
let _index = self.rev_locals.push(SmallVec::new());
debug_assert_eq!(index, _index);
}
} }
index index
} }
@ -332,7 +338,7 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
let is_sized = !self.feature_unsized_locals let is_sized = !self.feature_unsized_locals
|| self.local_decls[local].ty.is_sized(self.tcx, self.param_env); || self.local_decls[local].ty.is_sized(self.tcx, self.param_env);
if is_sized { if is_sized {
self.rev_locals.ensure_contains_elem(value, SmallVec::new).push(local); self.rev_locals[value].push(local);
} }
} }