bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

suggest adding a #[cfg(test)] to test modules

Browse source 
remove a empty line

import `module_to_string`

use `contains("test")`

show a suggestion in case module starts_with/ends_with "test"

replace `parent` with `containing`
This commit is contained in:
Takayuki Maeda 2021-10-23 18:55:02 +09:00
parent 3ee016ae4d
commit 6f8ad6d83a
6 changed files with 264 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_lint/src/context.rs
View file

@ -671,7 +671,7 @@ pub trait LintContext: Sized {
BuiltinLintDiagnostics::UnknownCrateTypes(span, note, sugg) => {
db.span_suggestion(span, &note, sugg, Applicability::MaybeIncorrect);
}
BuiltinLintDiagnostics::UnusedImports(message, replaces) => {
BuiltinLintDiagnostics::UnusedImports(message, replaces, in_test_module) => {
if !replaces.is_empty() {
db.tool_only_multipart_suggestion(
&message,
@ -679,6 +679,14 @@ pub trait LintContext: Sized {
Applicability::MachineApplicable,
);
}
if let Some(span) = in_test_module {
let def_span = self.sess().source_map().guess_head_span(span);
db.span_help(
span.shrink_to_lo().to(def_span),
"consider adding a `#[cfg(test)]` to the containing module",
);
}
}
BuiltinLintDiagnostics::RedundantImport(spans, ident) => {
for (span, is_imported) in spans {