bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

use body's param-env when checking if type needs drop

Browse source
This commit is contained in:
Michael Goulet 2022-07-17 10:56:12 -07:00
parent c2ecd3af87
commit 6d2bd541e0
3 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_mir_build/src/check_unsafety.rs
View file

@ -431,9 +431,9 @@ impl<'a, 'tcx> Visitor<'a, 'tcx> for UnsafetyVisitor<'a, 'tcx> {
let lhs = &self.thir[lhs];
if let ty::Adt(adt_def, _) = lhs.ty.kind() && adt_def.is_union() {
if let Some((assigned_ty, assignment_span)) = self.assignment_info {
if assigned_ty.needs_drop(self.tcx, self.tcx.param_env(adt_def.did())) {
if assigned_ty.needs_drop(self.tcx, self.param_env) {
// This would be unsafe, but should be outright impossible since we reject such unions.
self.tcx.sess.delay_span_bug(assignment_span, "union fields that need dropping should be impossible");
self.tcx.sess.delay_span_bug(assignment_span, format!("union fields that need dropping should be impossible: {assigned_ty}"));
}
} else {
self.requires_unsafe(expr.span, AccessToUnionField);