bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #127935 - tgross35:binary_asm_labels-x86-only, r=estebank,Urgau

Browse source 
Change `binary_asm_labels` to only fire on x86 and x86_64

In <https://github.com/rust-lang/rust/pull/126922>, the `binary_asm_labels` lint was added which flags labels such as `0:` and `1:`. Before that change, LLVM was giving a confusing error on x86/x86_64 because of an incorrect interpretation.

However, targets other than x86 and x86_64 never had the error message and have not been a problem. This means that the lint was causing code that previously worked to start failing (e.g. `compiler_builtins`), rather than only providing a more clear messages where there has always been an error.

Adjust the lint to only fire on x86 and x86_64 assembly to avoid this regression.

Also update the help message.

Fixes: https://github.com/rust-lang/rust/issues/127821
This commit is contained in:
Trevor Gross 2024-07-19 03:27:50 -05:00 • committed by GitHub
commit 6bdf9bd276
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 77 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_lint/src/lints.rs
View file

@ -2074,7 +2074,9 @@ pub enum InvalidAsmLabel {
missing_precise_span: bool,
},
#[diag(lint_invalid_asm_label_binary)]
#[note]
#[help]
#[note(lint_note1)]
#[note(lint_note2)]
Binary {
#[note(lint_invalid_asm_label_no_span)]
missing_precise_span: bool,