bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Check drop is trivial before checking ty needs drop

Browse source
This commit is contained in:
Michael Goulet 2024-11-21 23:20:59 +00:00
parent af0d566e76
commit 69a38de977
12 changed files with 57 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_const_eval/src/check_consts/qualifs.rs
View file

@ -175,6 +175,11 @@ impl Qualif for NeedsNonConstDrop {
return false;
}
// If this doesn't need drop at all, then don't select `~const Destruct`.
if !ty.needs_drop(cx.tcx, cx.typing_env) {
return false;
}
// We check that the type is `~const Destruct` since that will verify that
// the type is both `~const Drop` (if a drop impl exists for the adt), *and*
// that the components of this type are also `~const Destruct`. This
@ -203,7 +208,7 @@ impl Qualif for NeedsNonConstDrop {
// in its value since:
// 1. The destructor may have `~const` bounds which are not present on the type.
// Someone needs to check that those are satisfied.
// While this could be done instead satisfied by checking that the `~const Drop`
// While this could be instead satisfied by checking that the `~const Drop`
// impl holds (i.e. replicating part of the `in_any_value_of_ty` logic above),
// even in this case, we have another problem, which is,
// 2. The destructor may *modify* the operand being dropped, so even if we