bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

auto merge of #12523 : alexcrichton/rust/ignore-some-windows-tests, r=pnkfelix

Browse source 
These two tests are notoriously flaky on the windows bots right now, so I'm
ignoring them until I can investigate them some more. The truncate_works test
has been flaky for quite some time, but it has gotten much worse recently. The
test_exists test has been flaky since the recent std::run rewrite landed.
Finally, the "unix pipe" test failure is a recent discovery on the try bots. I
haven't seen this failing much, but better safe than sorry!

cc #12516
This commit is contained in:
bors 2014-02-24 12:42:02 -08:00
commit 68a4f7d9ba
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/libstd/io/fs.rs
View file

@ -1106,9 +1106,8 @@ mod test {
file.fsync().unwrap(); file.fsync().unwrap();
file.datasync().unwrap(); file.datasync().unwrap();
drop(file); drop(file);
}) } #[ignore(cfg(windows))])
#[ignore(cfg(windows))] // FIXME(#11638)
iotest!(fn truncate_works() { iotest!(fn truncate_works() {
let tmpdir = tmpdir(); let tmpdir = tmpdir();
let path = tmpdir.join("in.txt"); let path = tmpdir.join("in.txt");
@ -1138,7 +1137,7 @@ mod test {
assert_eq!(File::open(&path).read_to_end().unwrap(), assert_eq!(File::open(&path).read_to_end().unwrap(),
(bytes!("fo", 0, 0, 0, 0, "wut")).to_owned()); (bytes!("fo", 0, 0, 0, 0, "wut")).to_owned());
drop(file); drop(file);
}) } #[ignore(cfg(windows))]) // FIXME(#11638)
iotest!(fn open_flavors() { iotest!(fn open_flavors() {
let tmpdir = tmpdir(); let tmpdir = tmpdir();

2
src/libstd/io/net/unix.rs
View file

@ -192,7 +192,7 @@ mod tests {
}, proc(_client) { }, proc(_client) {
// drop the client // drop the client
}) })
}) } #[ignore(cfg(windows))]) // FIXME(#12516)
iotest!(fn write_begone() { iotest!(fn write_begone() {
smalltest(proc(mut server) { smalltest(proc(mut server) {

6
src/libstd/io/process.rs
View file

@ -814,7 +814,10 @@ mod tests {
} }
#[cfg(windows)] #[cfg(windows)]
pub fn sleeper() -> Process { pub fn sleeper() -> Process {
Process::new("timeout", [~"1000"]).unwrap() // There's a `timeout` command on windows, but it doesn't like having
// its output piped, so instead just ping ourselves a few times with
// gaps inbetweeen so we're sure this process is alive for awhile
Process::new("ping", [~"127.0.0.1", ~"-n", ~"1000"]).unwrap()
} }
iotest!(fn test_kill() { iotest!(fn test_kill() {
@ -823,7 +826,6 @@ mod tests {
assert!(!p.wait().success()); assert!(!p.wait().success());
}) })
#[ignore(cfg(windows))]
iotest!(fn test_exists() { iotest!(fn test_exists() {
let mut p = sleeper(); let mut p = sleeper();
assert!(Process::kill(p.id(), 0).is_ok()); assert!(Process::kill(p.id(), 0).is_ok());