bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: Fix duplicated impls with generics

Browse source 
The same type can appear multiple times in impls so we need to use a set
to avoid adding it multiple times.
This commit is contained in:
Oliver Middleton 2017-10-29 18:21:20 +00:00
parent 7da9a5e178
commit 676b4bbdc4
2 changed files with 29 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/librustdoc/html/render.rs
View file

@ -1325,7 +1325,7 @@ impl DocFolder for Cache {
// Figure out the id of this impl. This may map to a
// primitive rather than always to a struct/enum.
// Note: matching twice to restrict the lifetime of the `i` borrow.
let mut dids = vec![];
let mut dids = FxHashSet();
if let clean::Item { inner: clean::ImplItem(ref i), .. } = item {
let masked_trait = i.trait_.def_id().map_or(false,
|d| self.masked_crates.contains(&d.krate));
@ -1335,7 +1335,7 @@ impl DocFolder for Cache {
clean::BorrowedRef {
type_: box clean::ResolvedPath { did, .. }, ..
} => {
dids.push(did);
dids.insert(did);
}
ref t => {
let did = t.primitive_type().and_then(|t| {
@ -1343,7 +1343,7 @@ impl DocFolder for Cache {
});
if let Some(did) = did {
dids.push(did);
dids.insert(did);
}
}
}
@ -1352,7 +1352,7 @@ impl DocFolder for Cache {
if let Some(generics) = i.trait_.as_ref().and_then(|t| t.generics()) {
for bound in generics {
if let Some(did) = bound.def_id() {
dids.push(did);
dids.insert(did);
}
}
}